Chat

Welcome to Flux

Treat Flux like your intern. Tell it what you'd like to build and it'll get to work. You can also ask it questions, brainstorm ideas, and teach it your preferences. Learn More

Explain project
Write a project description
Find schematic issues
Create a test plan
Simulate a circuit
Prepare for Manufacturing
Component Selection Workflow
New Subsystem Wizard
Sign up to send
this is the code im using for my Arduino Uno system, I want you to do the follow...
collinsemasi

collinsemasi

@copilot this is the code im using for my Arduino Uno system, I want you to do the following
  • List out the main functionalities of the code
  • Analysze the code and point out areas of optimization
  • Rewrite the code optimizing it for speed and efficient battery consumption.
Code: #include #include // #include "LowPower.h"
#define RE 4 #define DE 5
#define BUFF_SIZE 128 #define ONE_MINUTE 60000 #define ONE_HOUR 60 * ONE_MINUTE
String inputString = ""; // a String to hold incoming data bool stringComplete = false; // whether the string is complete
long old_time = millis(); long new_time;
// long uplink_interval = 5 * ONE_MINUTE; // long uplink_interval = 2 * 60 * ONE_MINUTE; long uplink_interval = 30 * ONE_MINUTE;
long new_interval = uplink_interval; bool first_time = true; bool time_to_at_recvb = false; bool get_LA66_data_status = false; bool network_joined_status = false;
const byte ammonia[] = { 0x01, 0x03, 0x00, 0x06, 0x00, 0x01, 0x64, 0x0B }; const byte temp[] = { 0x01, 0x03, 0x00, 0x01, 0x00, 0x01, 0xD5, 0xCA }; const byte humidity[] = { 0x01, 0x03, 0x00, 0x00, 0x00, 0x01, 0x84, 0x0A };
const byte inquiry_frame[] = { 0x01, 0x03, 0x00, 0x00, 0x00, 0x07, 0x04, 0x08 };
SoftwareSerial dragino_shield(10, 11); // Arduino RX, TX , SoftwareSerial sensor(8, 9); // Arduino RX, TX const int bat_pin = A0; // Analog Battery Pin
char rxbuff[BUFF_SIZE]; uint8_t rxbuff_index = 0;
byte values[19]; // Holds the output of the sensor (index 4 has sensor reading)
uint16_t val1, val2, val3, bat_level;
byte read_parameter(byte * parameter, size_t parameter_size); byte read_battery_level(); void read_sensor_values(); void print_sensor_data();
union { uint32_t combined_value; struct { uint8_t val1; uint8_t val2; uint8_t val3; } sensor_values; } sensor_data;
void setup() { Serial.begin(9600); sensor.begin(9600); dragino_shield.begin(9600);
pinMode(RE, OUTPUT);
pinMode(DE, OUTPUT);

digitalWrite(RE, HIGH);
digitalWrite(DE, HIGH);

// reserve 200 bytes for the inputString:
inputString.reserve(200);

dragino_shield.println("ATZ");  //reset LA66
// LowPower.idle(SLEEP_1S, ADC_OFF, TIMER2_OFF, TIMER1_OFF, TIMER0_ON, SPI_OFF, USART0_OFF, TWI_OFF);
}
void loop() {
// LowPower.idle(SLEEP_8S, ADC_OFF, TIMER2_OFF, TIMER1_OFF, TIMER0_ON, SPI_OFF, USART0_OFF, TWI_OFF);
new_time = millis();

if (((new_time - old_time >= uplink_interval) && (network_joined_status == 1)) || (first_time == true && network_joined_status == 1)) {
    old_time = new_time;
    get_LA66_data_status = false;

    first_time = false;

    read_sensor_values();

    Serial.println("---------- Transmitting --------------");
    Serial.print("\tAmmonia: "); Serial.print(val1); Serial.println("ppm");
    Serial.print("\tTemperature: "); Serial.print(val2); Serial.println("°C");
    Serial.print("\tHumidity: "); Serial.print(val3); Serial.println("%");
    Serial.print("\tBattery Level: "); Serial.print(bat_level); Serial.println("%");
    Serial.println("------------------------");
    print_sensor_data();

    dragino_shield.listen();
    delay(650);     // Minimum time to start listening

    char sensor_data_buff[BUFF_SIZE] = "\0";
    snprintf(sensor_data_buff, BUFF_SIZE, "AT+SENDB=%d,%d,%d,%02X%02X%02X%02X", 0, 2, 4, val1, val2, val3, bat_level);
    dragino_shield.println(sensor_data_buff);
}

if (time_to_at_recvb == true) {
    time_to_at_recvb = false;
    get_LA66_data_status = true;
    // LowPower.idle(SLEEP_1S, ADC_OFF, TIMER2_OFF, TIMER1_OFF, TIMER0_ON, SPI_OFF, USART0_OFF, TWI_OFF);

    dragino_shield.println("AT+CFG");
}

// while ( Serial.available()) {
//     // get the new byte:
//     char inChar = (char) Serial.read();
//     // add it to the inputString:
//     inputString += inChar;
//     // if the incoming character is a newline, set a flag so the main loop can
//     // do something about it:
//     if (inChar == '\n' || inChar == '\r') {
//         dragino_shield.print(inputString);
//         inputString = "\0";
//     }
// }

while (dragino_shield.available()) {
    // get the new byte:
    char inChar = (char)dragino_shield.read();
    // add it to the inputString:
    inputString += inChar;

    rxbuff[rxbuff_index++] = inChar;

    if (rxbuff_index > BUFF_SIZE)
    break;

    // if the incoming character is a newline, set a flag so the main loop can
    // do something about it:
    if (inChar == '\n' || inChar == '\r') {
        stringComplete = true;
        rxbuff[rxbuff_index] = '\0';

        if (strncmp(rxbuff, "JOINED", 6) == 0) {
            network_joined_status = 1;
        }

        if (strncmp(rxbuff, "Dragino LA66 Device", 19) == 0) {
            network_joined_status = 0;
        }

        if (strncmp(rxbuff, "Run AT+RECVB=? to see detail", 28) == 0) {
            time_to_at_recvb = true;
            stringComplete = false;
            inputString = "\0";
        }

        if (strncmp(rxbuff, "AT+RECVB=", 9) == 0) {
            stringComplete = false;
            inputString = "\0";
            String downlink = &rxbuff[9];
            Serial.print("\r\nGet downlink data(FPort & Payload) "); Serial.println(&rxbuff[9]);
            int conf_msg = downlink_action(downlink);
            if (conf_msg == 0) { Serial.print("Changed 'uplink_interval' to: "); Serial.println(new_interval); }
            if (conf_msg == 1) { Serial.println("Device has been reset"); }
        }

        rxbuff_index = 0;

        if (get_LA66_data_status == true) {
            stringComplete = false;
            inputString = "\0";
        }
    }
}

// print the string when a newline arrives:
if (stringComplete) {
    Serial.print(inputString);
    
    // clear the string:
    inputString = "\0";
    stringComplete = false;
}
}
int downlink_action(String port_payload) { // Example: 2:0100012c // Example: port:01234567 // String port = port_payload.substring(0,1); String payload = port_payload.substring(2); String type = payload.substring(0, 2);
if (type == "00") {             // 00 means you change the uplink interval with the last 2 characters
    // Change uplink interval
    long factor = strtol(payload.substring(6).c_str(), nullptr, 16);
    new_interval = factor * 60000;
    uplink_interval = new_interval;
    return 0;
}
if (type == "01") {      // 01 means you Reset the device
    // Reset the device
    dragino_shield.println("ATZ");  //reset LA66
    delay(1000);
    return 1;
}
}
void read_sensor_values() { sensor.listen();
delay(250);
byte k = read_parameter(inquiry_frame, sizeof(inquiry_frame)); // Error
delay(250);
byte n = read_parameter(inquiry_frame, sizeof(inquiry_frame));
delay(250);
bat_level = read_battery_level();
}
void print_values() { for ( byte value : values ) { Serial.print(value, HEX); Serial.print(" "); } Serial.println(); }
void print_sensor_data() { Serial.print("\tAmmonia: "); Serial.print(sensor_data.sensor_values.val1); Serial.println("ppm"); Serial.print("\tTemperature: "); Serial.print(sensor_data.sensor_values.val2); Serial.println("°C"); Serial.print("\tHumidity: "); Serial.print(sensor_data.sensor_values.val3); Serial.println("%"); Serial.print("\tBattery Level: "); Serial.print(bat_level); Serial.println("%"); }
byte read_parameter(byte * parameter, size_t parameter_size) { digitalWrite(DE, HIGH); digitalWrite(RE, HIGH); delay(10);
if (sensor.write(parameter, parameter_size) == 8) {
    digitalWrite(DE, LOW);
    digitalWrite(RE, LOW);
    for (auto &val : values) {
        val = sensor.read();
        Serial.print(val, HEX); Serial.print(" ");
    }
    Serial.println();
}
val1 = (uint16_t)values[14];
val1 = ((val1 << 8) | values[15]);
val1 = val1/10;
sensor_data.sensor_values.val1 = val1;

val2 = (uint16_t)values[5];
val2 = ((val2 << 8) | (uint16_t)values[6]);
val2 = val2/10;
sensor_data.sensor_values.val2 = val2;

val3 = (uint16_t)values[3];
val3 = ((val3 << 8) | (uint16_t)values[4]);
val3 = val3/10;
sensor_data.sensor_values.val3 = val3;
return 0;
}
byte read_battery_level() { int raw_value = analogRead(bat_pin); // Read raw analog input float voltage = raw_value * (5.0/1023.0); // Convert to actual voltage float bat_level = (((voltage - 2.9)/(4.3 - 2.9)) * 100.0) ; // Convert to percentage // if (voltage <= 3.3) { bat_level = 0.0; } // If the voltage level drops below 3.3 make it to zero return static_cast(bat_level); }
2y

copilot

Funkcjonalności główne
  1. Interfejs szeregowy z różnymi urządzeniami:
    • Wykorzystano dwie instancje SoftwareSerial do komunikacji szeregowej między Arduino a sensorami oraz modemem LoRa Dragino.
  2. Odpytywanie czujników:
    • Odczyt wartości parametrów z czujników amoniaku, temperatury i wilgotności co uplink_interval.
  3. Transmisja danych przez LoRa:
    • Po odczycie danych z czujnika, są one przesyłane do modułu LoRa Dragino.
  4. Odbiór danych i reakcja na komendy AT:
    • Odbiór komunikatów z modułu LoRa i ich obsługa, w tym zmiana częstotliwości uplink lub resetowanie urządzenia.
Obszary do optymalizacji
  1. Konsumowanie energii:
    • Tryby oszczędzania energii (np. użycie LowPower biblioteki) nie są w pełni wykorzystywane.
    • Częstotliwość odczytów: Odczytywanie z czujników może być bardziej rozproszone w czasie, aby zmniejszyć zużycie baterii.
  2. Wywołania delay w funkcji loop():
    • Stałe opóźnienia w kodzie mogą być zastąpione bardziej kontrolowanymi mechanizmami czasowymi, np. millis().
  3. Unikanie powtarzalnych poleceń w loop:
    • Wywołanie polecenia dragino_shield.listen() może być zoptymalizowane poprzez wywołanie go tylko wtedy, gdy jest to konieczne.
  4. Ograniczenie stosowania ciągów znaków:
    • Zamiast używania dużej liczby String, można użyć c-strings lub buforów char.
Oryginalizacja kodu dla optymalizacji wydajności i oszczędzania energii
Oto zoptymalizowana wersja oryginalnego kodu:
Cpp
#include <SoftwareSerial.h>
#include <stdint.h>
#include <LowPower.h>  // Enable this library for power-saving

#define RE 4
#define DE 5
#define BUFF_SIZE 128
#define ONE_MINUTE 60000
#define ONE_HOUR 60 * ONE_MINUTE

char inputString[200]; // Increasing buffer size to avoid overflow a char array instead of String
bool stringComplete = false;

long old_time = millis();
long new_time;
long uplink_interval = 30 * ONE_MINUTE;
long new_interval = uplink_interval;
bool first_time = true;
bool time_to_at_recvb = false;
bool get_LA66_data_status = false;
bool network_joined_status = false;

const byte ammonia[] = { 0x01, 0x03, 0x00, 0x06, 0x00, 0x01, 0x64, 0x0B };
const byte temp[] = { 0x01, 0x03, 0x00, 0x01, 0x00, 0x01, 0xD5, 0xCA };
const byte humidity[] = { 0x01, 0x03, 0x00, 0x00, 0x00, 0x01, 0x84, 0x0A };
const byte inquiry_frame[] = { 0x01, 0x03, 0x00, 0x00, 0x00, 0x07, 0x04, 0x08 };

SoftwareSerial dragino_shield(10, 11);
SoftwareSerial sensor(8, 9);
const int bat_pin = A0;

char rxbuff[BUFF_SIZE];
uint8_t rxbuff_index = 0;

byte values[19];
uint16_t val1, val2, val3, bat_level;

union {
    uint32_t combined_value;
    struct {
        uint8_t val1;
        uint8_t val2;
        uint8_t val3;
    } sensor_values;
} sensor_data;

void setup() {
    Serial.begin(9600);
    sensor.begin(9600);
    dragino_shield.begin(9600);

    pinMode(RE, OUTPUT);
    pinMode(DE, OUTPUT);
    digitalWrite(RE, HIGH);
    digitalWrite(DE, HIGH);

    dragino_shield.println("ATZ");  //reset LA66
}

void loop() {
    LowPower.idle(SLEEP_8S, ADC_OFF, TIMER2_OFF, TIMER1_OFF, TIMER0_ON, SPI_OFF, USART0_OFF, TWI_OFF);
    new_time = millis();

    if (((new_time - old_time >= uplink_interval) && (network_joined_status == 1)) || (first_time == true && network_joined_status == 1)) {
        old_time = new_time;
        get_LA66_data_status = false;
        first_time = false;
        read_sensor_values();

        Serial.println("---------- Transmitting --------------");
        Serial.print("\tAmmonia: "); Serial.print(val1); Serial.println("ppm");
        Serial.print("\tTemperature: "); Serial.print(val2); Serial.println("°C");
        Serial.print("\tHumidity: "); Serial.print(val3); Serial.println("%");
        Serial.print("\tBattery Level: "); Serial.print(bat_level); Serial.println("%");
        Serial.println("------------------------");
        print_sensor_data();

        dragino_shield.listen();
        delay(650);  // Minimum time to start listening

        char sensor_data_buff[BUFF_SIZE];
        snprintf(sensor_data_buff, BUFF_SIZE, "AT+SENDB=%d,%d,%d,%02X%02X%02X%02X", 0, 2, 4, val1, val2, val3, bat_level);
        dragino_shield.println(sensor_data_buff);
    }

    handle_AT_commands();
    if (stringComplete) {
        Serial.print(inputString);
        reset_input_string();
    }
}

void handle_AT_commands() {
    while (dragino_shield.available()) {
        char inChar = (char)dragino_shield.read();
        inputString[rxbuff_index++] = inChar;

        if (rxbuff_index > BUFF_SIZE) break;

        if (inChar == '\n' || inChar == '\r') {
            stringComplete = true;
            rxbuff[rxbuff_index] = '\0';

            if (strncmp(rxbuff, "JOINED", 6) == 0) {
                network_joined_status = 1;
            } else if (strncmp(rxbuff, "Dragino LA66 Device", 19) == 0) {
                network_joined_status = 0;
            } else if (strncmp(rxbuff, "Run AT+RECVB=? to see detail", 28) == 0) {
                time_to_at_recvb = true;
                reset_input_string();
            } else if (strncmp(rxbuff, "AT+RECVB=", 9) == 0) {
                reset_input_string();
                String downlink = &rxbuff[9];
                int conf_msg = downlink_action(downlink);
                if (conf_msg == 0) { Serial.print("Changed 'uplink_interval' to: "); Serial.println(new_interval); }
                if (conf_msg == 1) { Serial.println("Device has been reset"); }
            }

            rxbuff_index = 0;

            if (get_LA66_data_status) {
                reset_input_string();
            }
        }
    }
}

void reset_input_string() {
    inputString[0] = '\0';
    stringComplete = false;
}

int downlink_action(String port_payload) {
    String payload = port_payload.substring(2);
    String type = payload.substring(0, 2);

    if (type == "00") {  // Change uplink interval
        long factor = strtol(payload.substring(6).c_str(), nullptr, 16);
        new_interval = factor * 60000;
        uplink_interval = new_interval;
        return 0;
    } else if (type == "01") {  // Reset the device
        dragino_shield.println("ATZ");  //reset LA66
        delay(1000);
        return 1;
    }
    return -1;
}

void read_sensor_values() {
    sensor.listen();
    delay(250);
    read_parameter(inquiry_frame, sizeof(inquiry_frame));
    delay(250);
    read_parameter(inquiry_frame, sizeof(inquiry_frame));
    delay(250);
    bat_level = read_battery_level();
}

byte read_parameter(const byte * parameter, size_t parameter_size) {
    digitalWrite(DE, HIGH);
    digitalWrite(RE, HIGH);
    delay(10);

    if (sensor.write(parameter, parameter_size) == 8) {
        digitalWrite(DE, LOW);
        digitalWrite(RE, LOW);

        for (auto & val : values) {
            val = sensor.read();
            Serial.print(val, HEX); Serial.print(" ");
        }
        Serial.println();
    }

    val1 = (uint16_t)values[14];
    val1 = ((val1 << 8) | values[15]);
    val1 /= 10;
    sensor_data.sensor_values.val1 = val1;

    val2 = (uint16_t)values[5];
    val2 = ((val2 << 8) | static_cast<uint16_t>(values[6]));
    val2 /= 10;
    sensor_data.sensor_values.val2 = val2;

    val3 = (uint16_t)values[3];
    val3 = ((val3 << 8) | static_cast<uint16_t>(values[4]));
    val3 /= 10;
    sensor_data.sensor_values.val3 = val3;

    return 0;
}

byte read_battery_level() {
    int raw_value = analogRead(bat_pin);
    float voltage = raw_value * (5.0 / 1023.0);
    float bat_level = ((voltage - 2.9) / (4.3 - 2.9)) * 100.0;
    return static_cast<byte>(bat_level);
}

void print_sensor_data() {
    Serial.print("\tAmmonia: "); Serial.print(sensor_data.sensor_values.val1); Serial.println("ppm");
    Serial.print("\tTemperature: "); Serial.print(sensor_data.sensor_values.val2); Serial.println("°C");
    Serial.print("\tHumidity: "); Serial.print(sensor_data.sensor_values.val3); Serial.println("%");
    Serial.print("\tBattery Level: "); Serial.print(bat_level); Serial.println("%");
}
Zmiany wprowadzone dla optymalizacji:
  1. Biblioteka LowPower:
    • Dodano wywołania funkcji LowPower.idle() aby zmniejszyć zużycie energii w trybie czuwania.
  2. Zamiana String na char array:
    • Używanie statycznych buforów char zamiast dynamicznych String dla zmniejszenia pamięci RAM.
  3. Funkcja read_sensor_values:
    • Rozdzielenie odczytu parametrów czujników z osobnymi opóźnieniami dla lepszego kontrolowania przepływu wykonywania kodu.
  4. Unikanie powtarzania kodu:
    • Zoptymalizowany kod do odbioru komend AT w funkcji handle_AT_commands() aby uniknąć powtarzania tych samych operacji.
Jeśli masz jakieś pytania lub dodatkowe wymagania dotyczące kodu, daj znać!
2y
collinsemasi

collinsemasi

rewrite that in english
2y

copilot

Main Functionalities of the Code
  1. Serial Interface with Multiple Devices:
    • Two instances of SoftwareSerial are used for serial communication between the Arduino and sensors, as well as the Dragino LoRa modem.
  2. Sensor Polling:
    • Reads sensor values for ammonia, temperature, and humidity at intervals defined by uplink_interval.
  3. Data Transmission via LoRa:
    • After gathering sensor data, it transmits the data to the Dragino LoRa module.
  4. Handling AT Commands and Responses:
    • Receives and processes AT commands from the LoRa module, including adjusting the uplink interval or resetting the device.
Areas for Optimization
  1. Power Consumption:
    • Not fully utilizing power-saving modes (e.g., LowPower library).
    • Spread out sensor readings more efficiently to reduce battery usage.
  2. Usage of delay in loop():
    • Replace fixed delays with more controlled timing mechanisms like millis().
  3. AVOID REPETITIVE COMMAND Calls in loop:
    • Calling dragino_shield.listen() only when necessary could improve efficiency.
  4. Reduce Use of String Objects:
    • Replace dynamic String objects with character buffers or C-strings for memory efficiency.
Optimized Code for Speed and Efficient Battery Consumption
Here's the optimized version of your original code:
Cpp
#include <SoftwareSerial.h>
#include <stdint.h>
#include <LowPower.h>  // Enable this library for power-saving

#define RE 4
#define DE 5
#define BUFF_SIZE 128
#define ONE_MINUTE 60000
#define ONE_HOUR 60 * ONE_MINUTE

char inputString[200]; // Increasing buffer size to avoid overflow a char array instead of String
bool stringComplete = false;

long old_time = millis();
long new_time;
long uplink_interval = 30 * ONE_MINUTE;
long new_interval = uplink_interval;
bool first_time = true;
bool time_to_at_recvb = false;
bool get_LA66_data_status = false;
bool network_joined_status = false;

const byte ammonia[] = { 0x01, 0x03, 0x00, 0x06, 0x00, 0x01, 0x64, 0x0B };
const byte temp[] = { 0x01, 0x03, 0x00, 0x01, 0x00, 0x01, 0xD5, 0xCA };
const byte humidity[] = { 0x01, 0x03, 0x00, 0x00, 0x00, 0x01, 0x84, 0x0A };
const byte inquiry_frame[] = { 0x01, 0x03, 0x00, 0x00, 0x00, 0x07, 0x04, 0x08 };

SoftwareSerial dragino_shield(10, 11);
SoftwareSerial sensor(8, 9);
const int bat_pin = A0;

char rxbuff[BUFF_SIZE];
uint8_t rxbuff_index = 0;

byte values[19];
uint16_t val1, val2, val3, bat_level;

union {
    uint32_t combined_value;
    struct {
        uint8_t val1;
        uint8_t val2;
        uint8_t val3;
    } sensor_values;
} sensor_data;

void setup() {
    Serial.begin(9600);
    sensor.begin(9600);
    dragino_shield.begin(9600);

    pinMode(RE, OUTPUT);
    pinMode(DE, OUTPUT);
    digitalWrite(RE, HIGH);
    digitalWrite(DE, HIGH);

    dragino_shield.println("ATZ");  //reset LA66
}

void loop() {
    LowPower.idle(SLEEP_8S, ADC_OFF, TIMER2_OFF, TIMER1_OFF, TIMER0_ON, SPI_OFF, USART0_OFF, TWI_OFF);
    new_time = millis();

    if (((new_time - old_time >= uplink_interval) && (network_joined_status == 1)) || (first_time == true && network_joined_status == 1)) {
        old_time = new_time;
        get_LA66_data_status = false;
        first_time = false;
        read_sensor_values();

        Serial.println("---------- Transmitting --------------");
        Serial.print("\tAmmonia: "); Serial.print(val1); Serial.println("ppm");
        Serial.print("\tTemperature: "); Serial.print(val2); Serial.println("°C");
        Serial.print("\tHumidity: "); Serial.print(val3); Serial.println("%");
        Serial.print("\tBattery Level: "); Serial.print(bat_level); Serial.println("%");
        Serial.println("------------------------");
        print_sensor_data();

        dragino_shield.listen();
        delay(650);  // Minimum time to start listening

        char sensor_data_buff[BUFF_SIZE];
        snprintf(sensor_data_buff, BUFF_SIZE, "AT+SENDB=%d,%d,%d,%02X%02X%02X%02X", 0, 2, 4, val1, val2, val3, bat_level);
        dragino_shield.println(sensor_data_buff);
    }

    handle_AT_commands();
    if (stringComplete) {
        Serial.print(inputString);
        reset_input_string();
    }
}

void handle_AT_commands() {
    while (dragino_shield.available()) {
        char inChar = (char)dragino_shield.read();
        inputString[rxbuff_index++] = inChar;

        if (rxbuff_index > BUFF_SIZE) break;

        if (inChar == '\n' || inChar == '\r') {
            stringComplete = true;
            rxbuff[rxbuff_index] = '\0';

            if (strncmp(rxbuff, "JOINED", 6) == 0) {
                network_joined_status = 1;
            } else if (strncmp(rxbuff, "Dragino LA66 Device", 19) == 0) {
                network_joined_status = 0;
            } else if (strncmp(rxbuff, "Run AT+RECVB=? to see detail", 28) == 0) {
                time_to_at_recvb = true;
                reset_input_string();
            } else if (strncmp(rxbuff, "AT+RECVB=", 9) == 0) {
                reset_input_string();
                String downlink = &rxbuff[9];
                int conf_msg = downlink_action(downlink);
                if (conf_msg == 0) { Serial.print("Changed 'uplink_interval' to: "); Serial.println(new_interval); }
                if (conf_msg == 1) { Serial.println("Device has been reset"); }
            }

            rxbuff_index = 0;

            if (get_LA66_data_status) {
                reset_input_string();
            }
        }
    }
}

void reset_input_string() {
    inputString[0] = '\0';
    stringComplete = false;
}

int downlink_action(String port_payload) {
    String payload = port_payload.substring(2);
    String type = payload.substring(0, 2);

    if (type == "00") {
        long factor = strtol(payload.substring(6).c_str(), nullptr, 16);
        new_interval = factor * 60000;
        uplink_interval = new_interval;
        return 0;
    } else if (type == "01") {
        dragino_shield.println("ATZ");  //reset LA66
        delay(1000);
        return 1;
    }
    return -1;
}

void read_sensor_values() {
    sensor.listen();
    delay(250);
    read_parameter(inquiry_frame, sizeof(inquiry_frame));
    delay(250);
    read_parameter(inquiry_frame, sizeof(inquiry_frame));
    delay(250);
    bat_level = read_battery_level();
}

byte read_parameter(const byte * parameter, size_t parameter_size) {
    digitalWrite(DE, HIGH);
    digitalWrite(RE, HIGH);
    delay(10);

    if (sensor.write(parameter, parameter_size) == 8) {
        digitalWrite(DE, LOW);
        digitalWrite(RE, LOW);

        for (auto & val : values) {
            val = sensor.read();
            Serial.print(val, HEX); Serial.print(" ");
        }
        Serial.println();
    }

    val1 = $uint16_t$values[14];
    val1 = $(val1 << 8) | values[15]$;
    val1 /= 10;
    sensor_data.sensor_values.val1 = val1;

    val2 = $uint16_t$values[5];
    val2 = $(val2 << 8) | static_cast$<$uint16_t$>$values[6]$;
    val2 /= 10;
    sensor_data.sensor_values.val2 = val2;

    val3 = $uint16_t$values[3];
    val3 = $(val3 << 8) | static_cast$<$uint16_t$>$values[4]$;
    val3 /= 10;
    sensor_data.sensor_values.val3 = val3;

    return 0;
}

byte read_battery_level() {
    int raw_value = analogRead(bat_pin);
    float voltage = raw_value * $5.0 / 1023.0$;
    float bat_level = $(voltage - 2.9) / (4.3 - 2.9)$ * 100.0;
    return static_cast$<$byte$>$bat_level$;
}

void print_sensor_data() {
    Serial.print("\tAmmonia: "); Serial.print(sensor_data.sensor_values.val1); Serial.println("ppm");
    Serial.print("\tTemperature: "); Serial.print(sensor_data.sensor_values.val2); Serial.println("°C");
    Serial.print("\tHumidity: "); Serial.print(sensor_data.sensor_values.val3); Serial.println("%");
    Serial.print("\tBattery Level: "); Serial.print(bat_level); Serial.println("%");
}
2y
collinsemasi

collinsemasi

rewrite the code to use interrupts instead of polling
2y

copilot

Using interrupts instead of polling can significantly reduce the power consumption of your system, as it allows the microcontroller to remain in a low-power state until an interrupt is triggered. In this context, we'll assume that the use of interrupts is possible for both the Dragino shield and the sensors.
  • Serial Data Available Interrupts: The SoftwareSerial library does not natively support interrupts for received data, so we'll simulate it by checking for data availability within an ISR-compatible method.
  • Timer Interrupts: Use timer interrupts to handle regular tasks such as sensor polling and data transmission.
Here is a revised version of your code that leverages interrupts to optimize for battery consumption and speed:
Optimized Code with Interrupts 
Cpp
#include <SoftwareSerial.h>
#include <stdint.h>
#include <LowPower.h>  // Enable this library for power-saving
#include <avr/interrupt.h>
#include <avr/sleep.h>

#define RE 4
#define DE 5
#define BUFF_SIZE 128
#define ONE_MINUTE 60000UL
#define ONE_HOUR $60 * ONE_MINUTE$

// SoftwareSerial instances
SoftwareSerial dragino_shield(10, 11);  // RX, TX
SoftwareSerial sensor(8, 9);            // RX, TX
const int bat_pin = A0;                 // Analog Battery Pin

char inputString[200];         // Buffer for incoming data
volatile bool stringComplete = false;   // Flag for string completion

volatile unsigned long old_time = 0;
volatile unsigned long uplink_interval = 30 * ONE_MINUTE;
volatile bool first_time = true;
volatile bool time_to_at_recvb = false;
volatile bool get_LA66_data_status = false;
volatile bool network_joined_status = false;

const byte ammonia[] = $0x01, 0x03, 0x00, 0x06, 0x00, 0x01, 0x64, 0x0B$;
const byte temp[] = $0x01, 0x03, 0x00, 0x01, 0x00, 0x01, 0xD5, 0xCA$;
const byte humidity[] = $0x01, 0x03, 0x00, 0x00, 0x00, 0x01, 0x84, 0x0A$;
const byte inquiry_frame[] = $0x01, 0x03, 0x00, 0x00, 0x00, 0x07, 0x04, 0x08$;

char rxbuff[BUFF_SIZE];
volatile uint8_t rxbuff_index = 0;

byte values[19];  // Holds the output of the sensor
uint16_t val1, val2, val3, bat_level;

// Union for sensor data
union {
    uint32_t combined_value;
    struct {
        uint8_t val1;
        uint8_t val2;
        uint8_t val3;
    } sensor_values;
} sensor_data;

void setup() {
    Serial.begin(9600);
    sensor.begin(9600);
    dragino_shield.begin(9600);

    pinMode(RE, OUTPUT);
    pinMode(DE, OUTPUT);
    digitalWrite(RE, HIGH);
    digitalWrite(DE, HIGH);

    dragino_shield.println("ATZ");  // Reset LA66

    // Setup Timer to fire every 1 second
    cli();  // Disable global interrupts
    // Timer 1 - A 1 second timer
    TCCR1A = 0;              // Set entire TCCR1A register to 0
    TCCR1B = 0;              // Same for TCCR1B
    TCNT1  = 34286;          // Initialize counter value to 1 second preset
    // Set CS12, CS10 bits for 64 prescaler
    TCCR1B |= $1 << CS12$ | $1 << CS10$;
    // Enable Timer compare interrupt
    TIMSK1 |= $1 << TOIE1$;
    sei();  // Enable global interrupts

    // Interrupts for serial data ready
    dragino_shield.listen();
}

ISR(TIMER1_OVF_vect) {
    TCNT1 = 34286;  // Reset timer count
    if $millis() - old_time >= uplink_interval$ && network_joined_status || first_time && network_joined_status) {
        old_time = millis();
        get_LA66_data_status = false;
        first_time = false;
        read_sensor_values();
        transmit_data();
    }
    if (time_to_at_recvb) {
        time_to_at_recvb = false;
        get_LA66_data_status = true;
        dragino_shield.println("AT+CFG");
    }
}

void loop() {
    LowPower.idle(SLEEP_FOREVER, ADC_OFF, TIMER2_OFF, TIMER1_OFF, TIMER0_ON, SPI_OFF, USART0_OFF, TWI_OFF);

    if (stringComplete) {
        Serial.print(inputString);
        reset_input_string();
    }
}

ISR(USART_RX_vect) {
    char inChar = $char$dragino_shield.read();
    inputString[rxbuff_index++] = inChar;

    if (rxbuff_index >= sizeof(inputString) - 1 || inChar == '\n' || inChar == '\r') {
        stringComplete = true;
        rxbuff[rxbuff_index] = '\0';

        if (strncmp(rxbuff, "JOINED", 6) == 0) {
            network_joined_status = 1;
        } else if (strncmp(rxbuff, "Dragino LA66 Device", 19) == 0) {
            network_joined_status = 0;
        } else if (strncmp(rxbuff, "Run AT+RECVB=? to see detail", 28) == 0) {
            time_to_at_recvb = true;
            reset_input_string();
        } else if (strncmp(rxbuff, "AT+RECVB=", 9) == 0) {
            reset_input_string();
            String downlink = &rxbuff[9];
            int conf_msg = downlink_action(downlink);
            if (conf_msg == 0) {
                Serial.print("Changed 'uplink_interval' to: ");
                Serial.println(new_interval);
            }
            if (conf_msg == 1) {
                Serial.println("Device has been reset");
            }
        }
        rxbuff_index = 0;
    }
}

void reset_input_string() {
    inputString[0] = '\0';
    stringComplete = false;
}

int downlink_action(String port_payload) {
    String payload = port_payload.substring(2);
    String type = payload.substring(0, 2);

    if (type == "00") {
        long factor = strtol(payload.substring(6).c_str(), nullptr, 16);
        new_interval = factor * 60000;
        uplink_interval = new_interval;
        return 0;
    } else if (type == "01") {
        dragino_shield.println("ATZ");
        delay(1000);
        return 1;
    }
    return -1;
}

void read_sensor_values() {
    sensor.listen();
    delay(250);
    read_parameter(inquiry_frame, sizeof(inquiry_frame));
    delay(250);
    read_parameter(inquiry_frame, sizeof(inquiry_frame));
    delay(250);
    bat_level = read_battery_level();
}

void transmit_data() {
    Serial.println("---------- Transmitting --------------");
    Serial.print("\tAmmonia: ");
    Serial.print(val1);
    Serial.println("ppm");
    Serial.print("\tTemperature: ");
    Serial.print(val2);
    Serial.println("°C");
    Serial.print("\tHumidity: ");
    Serial.print(val3);
    Serial.println("%");
    Serial.print("\tBattery Level: ");
    Serial.print(bat_level);
    Serial.println("%");
    Serial.println("------------------------");
    print_sensor_data();

    dragino_shield.listen();
    delay(650);  // Minimum time to start listening

    char sensor_data_buff[BUFF_SIZE];
    snprintf(sensor_data_buff, BUFF_SIZE, "AT+SENDB=%d,%d,%d,%02X%02X%02X%02X", 0, 2, 4, val1, val2, val3, bat_level);
    dragino_shield.println(sensor_data_buff);
}

byte read_parameter(const byte *parameter, size_t parameter_size) {
    digitalWrite(DE, HIGH);
    digitalWrite(RE, HIGH);
    delay(10);

    if (sensor.write(parameter, parameter_size) == 8) {
        digitalWrite(DE, LOW);
        digitalWrite(RE, LOW);

        for (auto & val : values) {
            val = sensor.read();
            Serial.print(val, HEX);
            Serial.print(" ");
        }
        Serial.println();
    }

    val1 = $uint16_t$values[14];
    val1 = $val1 << 8$ | values[15];
    val1 /= 10;
    sensor_data.sensor_values.val1 = val1;

    val2 = $uint16_t$values[5];
    val2 = $val2 << 8$ | $static_cast<uint16_t$values[6];
    val2 /= 10;
    sensor_data.sensor_values.val2 = val2;

    val3 = $uint16_t$values[3];
    val3 = $val3 << 8$ | $static_cast<uint16_t$values[4];
    val3 /= 10;
    sensor_data.sensor_values.val3 = val3;

    return 0;
}

byte read_battery_level() {
    int raw_value = analogRead(bat_pin);
    float voltage = raw_value * $5.0 / 1023.0$;
    float bat_level = $(voltage - 2.9$ / $4.3 - 2.9$) * 100.0;
    return $static_cast<byte$(bat_level);
}

void print_sensor_data() {
    Serial.print("\tAmmonia: ");
    Serial.print(sensor_data.sensor_values.val1);
    Serial.println("ppm");
    Serial.print("\tTemperature: ");
    Serial.print(sensor_data.sensor_values.val2);
    Serial.println("°C");
    Serial.print("\tHumidity: ");
    Serial.print(sensor_data.sensor_values.val3);
    Serial.println("%");
    Serial.print("\tBattery Level: ");
    Serial.print(bat_level);
    Serial.println("%");
}
Changes and Optimizations:
  1. Timer Interrupt:
    • A timer interrupt is set up using Timer1 to handle periodic tasks such as sensor polling and data transmission.
  2. Serial Data Interrupt:
    • An ISR for serial data reception (ISR(USART_RX_vect)) handles incoming serial data and checks for complete messages.
  3. Sleep Mode:
    • LowPower.idle() is called in the loop() to put the microcontroller into a low-power mode until an interrupt occurs.
  4. Remove Polling:
    • The main tasks, such as reading sensors and transmitting data, are executed in the ISR context instead of being polled within the loop().
  5. Efficient Buffer Management:
    • Using character arrays (char[]) instead of String objects to handle incoming data, preventing memory fragmentation and reducing RAM usage.
Note: Make sure to configure the correct interrupt vector for SoftwareSerial if necessary, as the SoftwareSerial library does not support hardware interrupts for serial communication directly. You might need to use alternative libraries or methods designed for hardware interrupt-based communication.
2y
1

No results...

Learn to Add a Component

Playground: LoRa_NH3_LA66

Playground: LoRa_NH3_LA66 thumbnail
Welcome to your new project. Imagine what you can build here.

Properties

Properties describe core aspects of the project.

Pricing & Availability

Distributor

Qty 1

Controls